[Hub Generated] Review request for Microsoft.CostManagement to add version preview/2019-03-01-preview by taleib · Pull Request #5866 · Azure/azure-rest-api-specs

taleib · 2019-05-06T05:09:06Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2019-05-06T05:09:41Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2019-05-06T05:10:01Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5332

AutorestCI · 2019-05-06T05:10:30Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-05-06T05:10:33Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmplcqwdy1h/rest/specification/cost-management/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpmibf5a4k']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-06T05:11:37Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4830

azuresdkci · 2019-05-06T05:30:32Z

Can one of the admins verify this patch?

taleib · 2019-05-06T05:56:02Z

@noferrar

…-preview' of https://github.com/taleib/azure-rest-api-specs into dev-cost-management-Microsoft.CostManagement-2019-03-01-preview

jhendrixMSFT

Can you please remove the BOM from ExternalBillingAccountForecast.json

majastrz

Looks good from ARM side.

taleib · 2019-05-12T13:18:13Z

Can you please remove the BOM from ExternalBillingAccountForecast.json

resolved

…-preview' of https://github.com/taleib/azure-rest-api-specs into dev-cost-management-Microsoft.CostManagement-2019-03-01-preview

jhendrixMSFT · 2019-05-14T16:58:00Z

There are several model validation failures due to invalid examples that need to be addressed. Please see the following log.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=30021

taleib · 2019-05-16T10:58:28Z

There are several model validation failures due to invalid examples that need to be addressed. Please see the following log.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=30021

these errors are from another service and not Forecast. can we advance without addressing them?
is it okay for us to suppress all these errors not relatd to our PR?

…-preview' of https://github.com/taleib/azure-rest-api-specs into dev-cost-management-Microsoft.CostManagement-2019-03-01-preview

jhendrixMSFT · 2019-05-16T16:22:36Z

@taleib these errors cannot be suppressed. Please file an issue to track fixing them, then we can go ahead with the PR.

taleib · 2019-05-19T11:33:07Z

@taleib these errors cannot be suppressed. Please file an issue to track fixing them, then we can go ahead with the PR.

resolved

forecast external scope

784ba2a

AutorestCI mentioned this pull request May 6, 2019

[AutoPR cost-management/resource-manager] [Hub Generated] Review request for Microsoft.CostManagement to add version preview/2019-03-01-preview Azure/azure-sdk-for-python#5079

Closed

azuresdkci assigned jhendrixMSFT May 6, 2019

azuresdkci requested a review from jhendrixMSFT May 6, 2019 05:31

taleib and others added 8 commits May 6, 2019 09:03

endfile newline

a415de8

new line

6ca4723

fix

e3b5080

Update costmanagement.json

7e03363

using the externalBillingAccountName

3304634

Merge branch 'dev-cost-management-Microsoft.CostManagement-2019-03-01…

74fbc6f

…-preview' of https://github.com/taleib/azure-rest-api-specs into dev-cost-management-Microsoft.CostManagement-2019-03-01-preview

d

748a05f

changed response id

aafeba5

taleib assigned noferrar and noamben May 6, 2019

taleib added 2 commits May 6, 2019 15:18

fixed response

1cc0852

json formatting

1f6442d

jhendrixMSFT requested changes May 6, 2019

View reviewed changes

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 6, 2019

taleib and others added 3 commits May 7, 2019 00:28

bad char

3adf2c7

badc char

ea65c8e

add 2019-03-preview to Go SDK

581eaba

majastrz approved these changes May 7, 2019

View reviewed changes

majastrz removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 7, 2019

majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 7, 2019

updated readme file

06de9b9

taleib requested a review from jhendrixMSFT May 12, 2019 11:38

taleib added 4 commits May 12, 2019 14:47

Adds suppression to readme

d386758

Adds suppression to readme

91ce8df

Adds suppression to readme

4f25c6a

Adds suppression to readme

ec45194

taleib and others added 4 commits May 12, 2019 16:21

readme

cdfc69f

Merge branch 'dev-cost-management-Microsoft.CostManagement-2019-03-01…

35cc169

…-preview' of https://github.com/taleib/azure-rest-api-specs into dev-cost-management-Microsoft.CostManagement-2019-03-01-preview

Adds suppression to readme

79c14d8

Merge branch 'dev-cost-management-Microsoft.CostManagement-2019-03-01…

e63f6bb

…-preview' of https://github.com/taleib/azure-rest-api-specs into dev-cost-management-Microsoft.CostManagement-2019-03-01-preview

AutorestCI mentioned this pull request May 12, 2019

[AutoPR cost-management/resource-manager] [Hub Generated] Review request for Microsoft.CostManagement to add version preview/2019-03-01-preview Azure/azure-sdk-for-go#4779

Merged

taleib and others added 7 commits May 16, 2019 15:10

Adds suppression to readme

b49a3f2

Adds suppression to readme

32ac46b

Merge branch 'dev-cost-management-Microsoft.CostManagement-2019-03-01…

a9127d8

…-preview' of https://github.com/taleib/azure-rest-api-specs into dev-cost-management-Microsoft.CostManagement-2019-03-01-preview

Date time examples

7767e9a

no suppression

698b00a

showbacks changes

31d65b7

revert showbacks changes

5160ef2

Showback changes 19-5

f7ea289

AutorestCI mentioned this pull request May 19, 2019

[AutoPR cost-management/resource-manager] [Hub Generated] Review request for Microsoft.CostManagement to add version preview/2019-03-01-preview Azure/azure-sdk-for-python#5329

Merged

taleib added 2 commits May 19, 2019 14:51

formatting

217d249

minor change

a228e53

jhendrixMSFT approved these changes May 20, 2019

View reviewed changes

jhendrixMSFT merged commit 1a9dcf1 into Azure:master May 20, 2019

Conversation

taleib commented May 6, 2019

Contribution checklist:

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented May 6, 2019

Uh oh!

taleib commented May 6, 2019

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

taleib commented May 12, 2019

Uh oh!

jhendrixMSFT commented May 14, 2019

Uh oh!

taleib commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhendrixMSFT commented May 16, 2019

Uh oh!

taleib commented May 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AutorestCI commented May 6, 2019 •

edited

Loading

AutorestCI commented May 6, 2019 •

edited

Loading

AutorestCI commented May 6, 2019 •

edited

Loading

AutorestCI commented May 6, 2019 •

edited

Loading

AutorestCI commented May 6, 2019 •

edited

Loading

taleib commented May 16, 2019 •

edited

Loading